-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add session support #197
add session support #197
Conversation
Mostly looks good. I wonder if there are any security concerns with the 'secret' being public. If so, perhaps randomly generate it at launch? |
4a24d28
to
0f13070
Compare
@gemmaleigh sorry, all sorted now |
👍 |
Is there an example of how to use this in the docs? |
@gemmaleigh no, but our current docs are not in great shape, not sure about adding to them in their current form - do you think it's worth it? |
Is this work just setup for #205? |
it's helpful for that, but it's not just for that. I've had people ask how to add session support, and it's a clear need if you're wanting to keep data through a multi-page process. It might be a while before we get something like #205 as it's a big piece of work that needs to be done right. My point about the docs is we have a total rewrite over here: #158 and I'm not sure where docs on this would sit in current structure |
Is anything blocking #158 now? @edwardhorsford ? |
I've now added documentation, is this good to go now? |
👍 Thanks for adding the docs. |
this is basic functionality that provides some value, and is good groundwork for providing an auto-data-passing solution later on