Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add session support #197

Merged
merged 3 commits into from
Jun 15, 2016
Merged

add session support #197

merged 3 commits into from
Jun 15, 2016

Conversation

joelanman
Copy link
Contributor

this is basic functionality that provides some value, and is good groundwork for providing an auto-data-passing solution later on

@edwardhorsford
Copy link
Contributor

Mostly looks good. I wonder if there are any security concerns with the 'secret' being public. If so, perhaps randomly generate it at launch?

@gemmaleigh
Copy link
Contributor

This has the commits from #208 which haven't yet been merged into master.

Please merge #208 first and remove these commits so only 330d383 and 0f13070 are in this PR.

@joelanman
Copy link
Contributor Author

@gemmaleigh sorry, all sorted now

@gemmaleigh
Copy link
Contributor

👍

@gemmaleigh
Copy link
Contributor

Is there an example of how to use this in the docs?

@joelanman
Copy link
Contributor Author

@gemmaleigh no, but our current docs are not in great shape, not sure about adding to them in their current form - do you think it's worth it?

@gemmaleigh
Copy link
Contributor

Is this work just setup for #205?

@joelanman
Copy link
Contributor Author

it's helpful for that, but it's not just for that. I've had people ask how to add session support, and it's a clear need if you're wanting to keep data through a multi-page process. It might be a while before we get something like #205 as it's a big piece of work that needs to be done right.

My point about the docs is we have a total rewrite over here: #158 and I'm not sure where docs on this would sit in current structure

@timpaul
Copy link
Contributor

timpaul commented Jun 8, 2016

Is anything blocking #158 now? @edwardhorsford ?

@joelanman
Copy link
Contributor Author

I've now added documentation, is this good to go now?

@gemmaleigh
Copy link
Contributor

👍 Thanks for adding the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants